From 3d5ce44aa3c8d222338c5f1f505f782f61d47927 Mon Sep 17 00:00:00 2001 From: William Oldham Date: Tue, 19 Mar 2024 17:17:42 +0000 Subject: [PATCH] Stop ignoring console errors --- .eslintrc.js | 2 +- src/dev-cli/logging.ts | 2 ++ src/dev-cli/scraper.ts | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.eslintrc.js b/.eslintrc.js index 927283f..6ae9ceb 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -22,7 +22,7 @@ module.exports = { 'no-bitwise': 'off', 'no-underscore-dangle': 'off', '@typescript-eslint/no-explicit-any': 'off', - 'no-console': 'off', + 'no-console': ['error', { allow: ['warn', 'error'] }], '@typescript-eslint/no-this-alias': 'off', 'import/prefer-default-export': 'off', '@typescript-eslint/no-empty-function': 'off', diff --git a/src/dev-cli/logging.ts b/src/dev-cli/logging.ts index 1a519f4..5495f1d 100644 --- a/src/dev-cli/logging.ts +++ b/src/dev-cli/logging.ts @@ -1,5 +1,7 @@ import { inspect } from 'node:util'; export function logDeepObject(object: Record) { + // This is the dev cli, so we can use console.log + // eslint-disable-next-line no-console console.log(inspect(object, { showHidden: false, depth: null, colors: true })); } diff --git a/src/dev-cli/scraper.ts b/src/dev-cli/scraper.ts index 39f75f6..bc32af2 100644 --- a/src/dev-cli/scraper.ts +++ b/src/dev-cli/scraper.ts @@ -41,6 +41,8 @@ async function runBrowserScraping( args: ['--no-sandbox', '--disable-setuid-sandbox'], }); const page = await browser.newPage(); + // This is the dev cli, so we can use console.log + // eslint-disable-next-line no-console page.on('console', (message) => console.log(`${message.type().slice(0, 3).toUpperCase()} ${message.text()}`)); await page.goto(server.resolvedUrls.local[0]); await page.waitForFunction('!!window.scrape', { timeout: 5000 });