movie-web/native-app
1
0
Fork 0
mirror of https://github.com/movie-web/native-app.git synced 2025-09-13 05:43:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: address code review

Browse Source
This commit is contained in:
Adrian Castro
2024-02-04 18:36:21 +01:00
parent 54e270bf17
commit 4478366855
6 changed files with 53 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/expo/package.json
View File

@@ -1,5 +1,5 @@
{
"name": "movie-web",
"name": "@movie-web/mobile",
"version": "0.1.0",
"private": true,
"main": "expo-router/entry",

33
apps/expo/src/app/(tabs)/search/_layout.tsx
View File

@@ -47,28 +47,13 @@ export default function SearchScreen() {
async function fetchSearchResults(query: string): Promise<ItemData[]> {
const results = await searchTitle(query);
return results
.map((result) => {
switch (result.media_type) {
case "movie":
return {
id: result.id.toString(),
title: result.title,
posterUrl: getMediaPoster(result.poster_path),
year: new Date(result.release_date).getFullYear(),
type: result.media_type,
};
case "tv":
return {
id: result.id.toString(),
title: result.name,
posterUrl: getMediaPoster(result.poster_path),
year: new Date(result.first_air_date).getFullYear(),
type: result.media_type,
};
default:
return undefined;
}
})
.filter((item): item is ItemData => item !== undefined);
return results.map((result) => ({
id: result.id.toString(),
title: result.media_type === "tv" ? result.name : result.title,
posterUrl: getMediaPoster(result.poster_path),
year: new Date(
result.media_type === "tv" ? result.first_air_date : result.release_date,
).getFullYear(),
type: result.media_type,
}));
}

29
packages/tmdb/src/details.ts Normal file
View File

@@ -0,0 +1,29 @@
import type { MovieDetails, TvShowDetails } from "tmdb-ts";
import { tmdb } from "./util";
export async function fetchMediaDetails(
id: string,
type: "movie" | "tv",
): Promise<
{ type: "movie" | "tv"; result: TvShowDetails | MovieDetails } | undefined
> {
try {
let result: TvShowDetails | MovieDetails;
switch (type) {
case "tv":
result = await tmdb.tvShows.details(parseInt(id, 10));
break;
case "movie":
result = await tmdb.movies.details(parseInt(id, 10));
break;
default:
return undefined;
}
return { type, result };
} catch (ex) {
return undefined;
}
}

2
packages/tmdb/src/index.ts
View File

@@ -1,2 +1,4 @@
export const name = "tmdb";
export * from "./search";
export * from "./details";
export * from "./util";

39
packages/tmdb/src/search.ts
View File

@@ -1,9 +1,6 @@
import type { MovieDetails, TvShowDetails } from "tmdb-ts";
import { TMDB } from "tmdb-ts";
import type { MovieWithMediaType, TVWithMediaType } from "tmdb-ts";
const TMDB_API_KEY =
"eyJhbGciOiJIUzI1NiJ9.eyJhdWQiOiJkYTM1ZTgyMzE4OTc0NTgxNDJmZjljZTE4ODExNWRlNiIsInN1YiI6IjY0OTM0ZDQ1ODliNTYxMDExYzliZDVhMiIsInNjb3BlcyI6WyJhcGlfcmVhZCJdLCJ2ZXJzaW9uIjoxfQ.AzWnIcxPNgDwGdzeIZ_C3mRC_5_qy-Z-SRPglLjzlNc";
const tmdb = new TMDB(TMDB_API_KEY);
import { tmdb } from "./util";
export async function searchTitle(query: string) {
try {
@@ -18,38 +15,8 @@ export async function searchTitle(query: string) {
if (!results.length) throw new Error("No results found");
return results;
return results as unknown as MovieWithMediaType[] | TVWithMediaType[];
} catch (ex) {
throw new Error(`Error searching for title: ${(ex as Error).message}`);
}
}
export async function fetchMediaDetails(
id: string,
type: "movie" | "tv",
): Promise<
{ type: "movie" | "tv"; result: TvShowDetails | MovieDetails } | undefined
> {
try {
let result: TvShowDetails | MovieDetails;
switch (type) {
case "tv":
result = await tmdb.tvShows.details(parseInt(id, 10));
break;
case "movie":
result = await tmdb.movies.details(parseInt(id, 10));
break;
default:
return undefined;
}
return { type, result };
} catch (ex) {
return undefined;
}
}
export function getMediaPoster(posterPath: string): string {
return `https://image.tmdb.org/t/p/w185/${posterPath}`;
}

9
packages/tmdb/src/util.ts Normal file
View File

@@ -0,0 +1,9 @@
import { TMDB } from "tmdb-ts";
const TMDB_API_KEY =
"eyJhbGciOiJIUzI1NiJ9.eyJhdWQiOiJkYTM1ZTgyMzE4OTc0NTgxNDJmZjljZTE4ODExNWRlNiIsInN1YiI6IjY0OTM0ZDQ1ODliNTYxMDExYzliZDVhMiIsInNjb3BlcyI6WyJhcGlfcmVhZCJdLCJ2ZXJzaW9uIjoxfQ.AzWnIcxPNgDwGdzeIZ_C3mRC_5_qy-Z-SRPglLjzlNc";
export const tmdb = new TMDB(TMDB_API_KEY);
export function getMediaPoster(posterPath: string): string {
return `https://image.tmdb.org/t/p/w185/${posterPath}`;
}